fix(app): state management interaction tools#407
Merged
Conversation
Removed subscription to config changes and updated tool state handling.
sidvishnoi
reviewed
Oct 13, 2025
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
Looking good! I see some abstraction opportunities.
sidvishnoi
reviewed
Oct 14, 2025
Member
Author
|
there's a bug somewhere causing the dirty tabs to not update in real time, again. looking 👀 |
Deployment results
Logs #18648132115 |
Member
Author
proper use of valtio |
sidvishnoi
reviewed
Oct 17, 2025
sidvishnoi
reviewed
Oct 17, 2025
sidvishnoi
reviewed
Oct 17, 2025
sidvishnoi
reviewed
Oct 17, 2025
sidvishnoi
reviewed
Oct 17, 2025
sidvishnoi
reviewed
Oct 17, 2025
Member
|
@DarianM The preview broke at some stage 😭 Screen.Recording.2025-10-17.at.15.54.01.mov |
sidvishnoi
changed the title
sidvishnoi
approved these changes
Oct 18, 2025
sidvishnoi
reviewed
Oct 18, 2025
sidvishnoi
reviewed
Oct 18, 2025
sidvishnoi
requested changes
Oct 18, 2025
Member
sidvishnoi
left a comment
sidvishnoi
left a comment
There was a problem hiding this comment.
Let's bring in changes for widget route as well, otherwise it'll be broken if this PR is merged.
DarianM
changed the title
sidvishnoi
reviewed
Oct 20, 2025
sidvishnoi
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fix state subscription pattern in banner builder, causing the component to not behave whenever any property in the configuration object changed.
profileas prop to theBannerProfileinstead use snapshot in component as it re-rendered the entire route.UIStoreprovider caused entire app to re-render